Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: utilize grossYield for app display #2351

Merged
merged 2 commits into from
Sep 9, 2022
Merged

refactor: utilize grossYield for app display #2351

merged 2 commits into from
Sep 9, 2022

Conversation

okjintao
Copy link
Contributor

@okjintao okjintao commented Sep 9, 2022

Summary

  • ensure baseYield usage is removed
  • utilize grossYield for all displays

@okjintao okjintao added the enhancement New feature or request label Sep 9, 2022
@okjintao okjintao self-assigned this Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 51.1% 2165/4237
🟡 Branches 43.08% 775/1799
🟡 Functions 44.51% 539/1211
🟢 Lines 68.54% 15488/22598

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 8ebecf2

@okjintao okjintao merged commit f538391 into development Sep 9, 2022
@okjintao okjintao deleted the utilize-gross-yields branch September 9, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbasado mrbasado mrbasado approved these changes

@mranilrai mranilrai Awaiting requested review from mranilrai

Assignees

@okjintao okjintao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okjintao @mrbasado