Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord link revert #2373

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Discord link revert #2373

merged 2 commits into from
Sep 16, 2022

Conversation

mrbasado
Copy link
Collaborator

No description provided.

@GalloDaSballo
Copy link
Contributor

Not convinced it will provide any guarantee as even if we own the link the risk of hijacking is non-zero

On the other hand risk of simulating a pseudo-random string is lower

@GalloDaSballo
Copy link
Contributor

It may be possible to reproduce the string via boost as well, not sure

@mrbasado
Copy link
Collaborator Author

I agree this is more a product desire, I think there is value in making the discord.badger.com 301 redirect nginx server to point to whatever we want (this gives us more control if we use the link in permeant tweets and if discord increase number of boosts to keep this feature). In regards to the boost link Will now owns the minimal amount of boosts needed for the feature.

@GalloDaSballo
Copy link
Contributor

Don't think it's worth pushing the fix out with any urgency

I'd prefer listening to other people's thoughts

@GalloDaSballo
Copy link
Contributor

Correction the link is expired

@GalloDaSballo GalloDaSballo merged commit fb50d52 into master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants