Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add apy + modal to vault detail page #2406

Merged
merged 1 commit into from
Sep 30, 2022
Merged

feat: add apy + modal to vault detail page #2406

merged 1 commit into from
Sep 30, 2022

Conversation

mrbasado
Copy link
Collaborator

@mrbasado mrbasado commented Sep 29, 2022 •
edited
Loading

Screen Shot 2022-09-29 at 3 09 20 PM
Screen Shot 2022-09-29 at 3 09 23 PM

@mrbasado mrbasado requested a review from okjintao as a code owner September 29, 2022 20:03
@mrbasado mrbasado linked an issue Sep 29, 2022 that may be closed by this pull request
[feat. request]: Add APY to vault detail page for non influence vaults #2405
Closed
@mrbasado mrbasado requested a review from mranilrai September 29, 2022 20:38
@mrbasado mrbasado force-pushed the add-apy-modal-vault-detail-page branch from 3982be2 to 9b12b08 Compare September 30, 2022 15:00
@mrbasado mrbasado force-pushed the add-apy-modal-vault-detail-page branch from 9b12b08 to 8a36a59 Compare September 30, 2022 15:09
@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 51.61% 2201/4265
🟡 Branches 43.32% 788/1819
🟡 Functions 44.65% 542/1214
🟢 Lines 69.06% 15636/22642

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/components-v2/vault-detail/specs/VaultMetrics.tsx 84.21% (-15.79% 🔻) 66.67% (-33.33% 🔻) 50% (-50% 🔻) 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 8a36a59

@mrbasado mrbasado merged commit 3c7bf69 into development Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mranilrai mranilrai mranilrai approved these changes

@okjintao okjintao Awaiting requested review from okjintao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat. request]: Add APY to vault detail page for non influence vaults
2 participants
@mrbasado @mranilrai