Ukrainian language support #19

pavloslav · 2023-11-27T20:21:53Z

Completed all functions for Ukrainian (currency fractions are still a bit of mess, but it looks like there are like that in the original too)

Ballasi · 2023-11-27T20:55:25Z

Hey, I've seen you do a lot of work in here, thanks a lot!

Sorry for the delay -- I was a bit inactive the last few days. I will take a look and answer everything you've been sending tomorrow. Once again, sorry if I wasn't active before, but I will answer everything! Thanks again.

pavloslav · 2023-11-28T06:38:13Z

It's ok, take your time. Just merge it so we can move on.

Ballasi · 2023-12-11T12:52:12Z

Hey, sorry for the extended delay, I did an initial review on your commits, can you take a look at them?

Thanks a lot for the contribution, it means a lot :)

src/lang/uk.rs

pavloslav · 2023-12-11T20:35:03Z

Ok, I've closed the most issues. Still, several rustfmt::skip remain; and one more thing: I've added prefer() arguments description, but I think formatting is poor, and probably it should be split moved to specific languages. Any ideas?

Ballasi · 2023-12-12T15:09:43Z

src/num2words.rs

+    ///
+    /// Gender: **masculine/m/чоловічий/чол/ч**, feminine/f/жіночий/жін/ж, neuter/n/середній/сер/с
+    ///
+    /// Declenation: **nominative/nom/називний/н**, genitive/gen/родовий/р, dative/dat/давальний/д,


Declenation => Declination

Ballasi · 2023-12-12T15:12:58Z

src/lang/uk.rs

-const ORDINAL_FLEXIONS_PLURAL_SHORT: [&str; 6] = [
-    "і",  "х",  "м",  "х", "ми", "х",
-];
+const ORDINAL_FLEXIONS_PLURAL_SHORT: [&str; 6] = ["і", "х", "м", "х", "ми", "х"];

 #[rustfmt::skip]
 const NOUN_2ST_GROUP_HARD_DECLENSIONS: [[&str; 6]; 2] = [ //долар


You are using a lot of references to DECLENSIONS here, instead of DECLINATION. For consistency, I believe it would be better to have them be the same everywhere.

This can be easily modified using a sed command: find src -type f -exec sed -i 's/DECLENSIONS/DECLINATIONS/g' {} +

I often tell myself not to work when it's late… but that's the only way to work on side projects.

Ballasi · 2023-12-12T15:15:50Z

src/lang/uk.rs

+                NOUN_2ST_GROUP_HARD_DECLENSIONS[number_idx][declination_idx]
+            ),
+            Currency::RUB =>
+            //format!("рубл{}", NOUN_1ST_GROUP_MASCULINE_SOFT_DECLENSIONS[number_idx][declination_idx]),


there are still a lot of previously-used comments that are removed from usage, is this supposed to act like documentation?

Ballasi · 2023-12-12T15:16:01Z

src/lang/uk.rs

+            Currency::RUB =>
+            //format!("рубл{}", NOUN_1ST_GROUP_MASCULINE_SOFT_DECLENSIONS[number_idx][declination_idx]),
+            {
+                String::from("руській воєнний корабль іді нахуй")


or is this just a little troll with that haha :)

It just... won't fix. Maybe someday someone will be able to do it. But not me, not now.

I'll keep it for now haha! I probably won't keep it forever though, as I want my lib to be usable in the most cases possible (even though in theory the license added a "no warranty" section). I'll keep it for a few releases and will fix that later.

Thanks though for putting the actual thing in comments!

Ballasi · 2023-12-12T15:17:38Z

src/lang/uk.rs

+            Currency::ZAR => format!(
+                "ранд{}",
+                NOUN_2ST_GROUP_HARD_DECLENSIONS[number_idx][declination_idx]
+            ),
            //_ => currency.default_string(self.number == GrammaticalNumber::Plural),


related with #21, this is supposed to be my way of doing, by putting a "default value" through a default_string function. using non_exhaustive is better that this, but my initial plan was to keep this uncommented in case someone in the future adds a currency.

I've also added a bunch of currencies in the past just to make sure adding new currencies isn't supposed to happen often

I think currencies are updating more quickly.
In Ukraine, we had 3 currencies over the past 35 years (Soviet ruble, Ukrainian karbovanets, Ukrainian hryvnia), and expect Euro to be here in 10 years. There are some 180 currencies in the world; even if the average time of life of the currency is 200 year (clearly an overestimation), it still means one currency is changed in a year and 40 days.

Anyway, I think it's a good idea to leave it there - when the new currency will be added, this will at least help to fix the build for testing other languages.

Ballasi · 2023-12-12T15:19:53Z

src/lang/uk.rs

+            Currency::RUB =>
+            //format!("копійк{}", NOUN_1ST_GROUP_FEMININE_HARD_DECLENSIONS[number_idx][declination_idx]),
+            {
+                String::from("руській воєнний корабль іді нахуй")


I'm torn between keeping this or putting the original format! just to make sure the lib is usable haha

src/lang/uk.rs

Ballasi · 2023-12-12T15:24:04Z

Thank you for your hard work, it's very much appreciated!

I can be a little bit picky on my code review, it's just that I want it to be perfect, but your work is very well done, thank you again!

Closes Ballasi#15, closes Ballasi#16

Ballasi · 2023-12-14T21:24:36Z

Hey, one small thing: there also needs to be two lines added in README.md and src/lib.rs in the Supported languages section to add a note for Ukrainian!

…to ukrainian

pavloslav · 2023-12-14T22:02:58Z

Added to Supported languages.
Also rebased on current master, for cleaner merge.

Ballasi · 2023-12-14T22:09:39Z

README.md

+| Flag | Code              | ISO 639-1 | Language   | 42        |
+| ---- | ----------------- | --------- | ---------- | --------- |
+| 🇺🇸🇬🇧 | `Lang::English`   | `en`      | English    | forty-two |
+| 🇺🇦   | `Lang::Ukrainian` | `ua`      | Ukrainian  | сорок два |


ISO 639-1 code of Ukrainian is uk, not ua :)

Ballasi · 2023-12-14T22:10:51Z

src/lib.rs

+ * | Flag | Code              | ISO 639-1 | Language   | 42        |
+ * | ---- | ----------------- | --------- | ---------- | --------- |
+ * | 🇺🇸🇬🇧 | `Lang::English`   | `en`      | English    | forty-two |
+ * | 🇺🇦   | `Lang::Ukrainian` | `ua`      | Ukrainian  | сорок два |


pavloslav · 2023-12-15T06:14:01Z

Pavlo, you're working late once again...

pavloslav · 2023-12-15T06:21:19Z

Done

Ballasi · 2023-12-15T15:54:28Z

Thanks a lot Pavlo! that's very appreciated :)

pavloslav added 3 commits November 26, 2023 11:01

Added cardinal int support for Ukrainian

2a8e296

Added ordinals

284edb7

Ukrainian language complete

215c1d2

pavloslav added 2 commits November 30, 2023 09:27

Ukrainian: Some refactoring

a355118

Added description for Ukrainian

0ff73d7

Ballasi reviewed Dec 11, 2023

View reviewed changes

CR fixes

7727c2c

Ballasi reviewed Dec 12, 2023

View reviewed changes

pavloslav added 3 commits December 12, 2023 10:29

num2words: linting and -th ordinal_num fix for en (Ballasi#20)

a57bc21

Closes Ballasi#15, closes Ballasi#16

Terminology fix

3d765d3

Correct last fix (it's declension, I've checked twice)

6a42dbc

pavloslav added 10 commits December 14, 2023 23:47

Added cardinal int support for Ukrainian

17a8303

Added ordinals

a3433aa

Ukrainian language complete

d1b3fcf

Ukrainian: Some refactoring

e2edb1b

Added description for Ukrainian

76c81da

CR fixes

189f1b0

Terminology fix

5492ab1

Correct last fix (it's declension, I've checked twice)

81ee5fa

Merge branch 'ukrainian' of https://github.com/pavloslav/num2words in…

f08cf06

…to ukrainian

Added mentions of Ukrainian to lib.rs and README

c15887d

Ballasi reviewed Dec 14, 2023

View reviewed changes

Fixed ISO 639-1

44f0cc5

Ballasi added the language addition Previously unsupported language that is set to be implemented label Dec 15, 2023

Ballasi merged commit 7c762ac into Ballasi:master Dec 15, 2023

Ballasi mentioned this pull request Mar 27, 2024

Spanish Support #27

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ukrainian language support #19

Ukrainian language support #19

pavloslav commented Nov 27, 2023

Ballasi commented Nov 27, 2023

pavloslav commented Nov 28, 2023

Ballasi commented Dec 11, 2023

pavloslav commented Dec 11, 2023

Ballasi Dec 12, 2023

Ballasi Dec 12, 2023

pavloslav Dec 12, 2023

Ballasi Dec 12, 2023

Ballasi Dec 12, 2023

pavloslav Dec 12, 2023

Ballasi Dec 14, 2023

Ballasi Dec 12, 2023

pavloslav Dec 12, 2023

pavloslav Dec 12, 2023

Ballasi Dec 12, 2023

Ballasi commented Dec 12, 2023 •

edited

Loading

Ballasi commented Dec 14, 2023

pavloslav commented Dec 14, 2023

Ballasi Dec 14, 2023

Ballasi Dec 14, 2023

pavloslav commented Dec 15, 2023

pavloslav commented Dec 15, 2023

Ballasi commented Dec 15, 2023

Ukrainian language support #19

Ukrainian language support #19

Conversation

pavloslav commented Nov 27, 2023

Ballasi commented Nov 27, 2023

pavloslav commented Nov 28, 2023

Ballasi commented Dec 11, 2023

pavloslav commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ballasi commented Dec 12, 2023 • edited Loading

Ballasi commented Dec 14, 2023

pavloslav commented Dec 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavloslav commented Dec 15, 2023

pavloslav commented Dec 15, 2023

Ballasi commented Dec 15, 2023

Ballasi commented Dec 12, 2023 •

edited

Loading