Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already was some kind of duplicates strings elimination, this is just a PoC to also eliminate duplicate substrings.
This could be further improved because it is not retroactive, so if
abcd
is registered afterbc
, the string will bebcabcd
where it could only have beenabcd
.The substring resolution is a call to
str::find
, so it's a linear search (maybe even O(n²) ?) and is called for every strings, so it can be pretty expensive depending on the number of strings. For this reason it might be great to gate it behing a feature.