Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AragonDeployer and deploy script. #4

Merged
merged 7 commits into from
Sep 7, 2020
Merged

Add AragonDeployer and deploy script. #4

merged 7 commits into from
Sep 7, 2020

Conversation

cleanunicorn
Copy link
Contributor

@cleanunicorn cleanunicorn commented Sep 6, 2020

Adds:

  • AragonDeployer to do token and deposit in 2 different txs
  • deploy script
  • config management for mainnet / rinkeby / ropsten / ...

This is done in 2 steps because the Aragon has a UI bug.
aragon/aragon-apps#1062 (comment)

@cleanunicorn cleanunicorn changed the title [WIP] Add AragonDeployer and deploy script. Add AragonDeployer and deploy script. Sep 6, 2020
@DannyDesert
Copy link
Member

Adds:

  • AragonDeployer to do token and deposit in 2 different txs
  • deploy script
  • config management for mainnet / rinkeby / ropsten / ...

@cleanunicorn does this work now? I saw you were talking to someone on twitter about it

@cleanunicorn
Copy link
Contributor Author

@DannyDesert I spent my weekend figuring it out. We're good to go.

config.sample.js Outdated

// Rinkeby
rinkeby: {
url: 'https://mainnet.infura.io/v3/YOUR-INFURA-API-KEY',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be https://rinkeby.infura.io....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@cleanunicorn cleanunicorn merged commit 8167432 into master Sep 7, 2020
@cleanunicorn cleanunicorn deleted the deploy branch September 7, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants