Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings. Add nicer error messages for mmap files. #7

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix clippy warnings. Add nicer error messages for mmap files. #7

merged 1 commit into from
Nov 20, 2020

Conversation

piobab
Copy link
Contributor

@piobab piobab commented Nov 19, 2020

No description provided.

@piobab piobab mentioned this pull request Nov 19, 2020
Closed
kodieg
kodieg reviewed Nov 20, 2020
View reviewed changes
src/embedding.rs Outdated Show resolved Hide resolved
@piobab piobab force-pushed the fix-clippy-warnings branch from 2dcc6d8 to 8ee275c Compare November 20, 2020 09:02
kodieg
kodieg approved these changes Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@kodieg kodieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piobab piobab merged commit d09f752 into master Nov 20, 2020
@piobab piobab deleted the fix-clippy-warnings branch November 20, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodieg kodieg kodieg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piobab @kodieg