chore(pre-commit): bump version #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done in the beginning because of build issues, but was solved during the work on Bash-it#1897
| rev: 2.1.4 | ||
| rev: 2.1.5 |
There was a problem hiding this comment.
2.1.5 appears to just be this update:
This fix is not technically needed here since it applies to Pre-Commit 2.10.0+ and we're still on 2.3.0.
However, I'm inclined to allow it, assuming our tests pass.
There was a problem hiding this comment.
Which it seems they are.. so approve it? @davidpfarrell
|
I'm going to leave this for @NoahGorny to approve, since, although I think this change would not break anything, I'm also not sold that we need this change right now due to the version of Pre-Commit we're on. |
NoahGorny
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
I think its a good practice to use the latest released versions of things we use, so I approve this.
Thanks @georgettica and @davidpfarrell for your work here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done in the beginning because of build issues, but was solved during the work on #1897