Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/preexec: tests! #2072

Merged
merged 3 commits into from
Jan 27, 2022
Merged

lib/preexec: tests! #2072

merged 3 commits into from
Jan 27, 2022

Conversation

gaelicWizard
Copy link
Contributor

Description

Add some BATS tests for lib/preexec to prevent minor mistakes from becoming big issues. 🙃

Motivation and Context

My patch for lib/preexec broke at least one use case, and alsö had a glaring logic-inversion that broke everything. Let's not do that again!

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the lib/preexec branch 5 times, most recently from e76dd7f to 1b29cdd Compare January 27, 2022 19:17
@gaelicWizard gaelicWizard force-pushed the lib/preexec branch 2 times, most recently from 40686e8 to e71e7b5 Compare January 27, 2022 20:09
@gaelicWizard gaelicWizard marked this pull request as ready for review January 27, 2022 20:10
@gaelicWizard
Copy link
Contributor Author

I'd like to get this merged to @Bash-it master asafp! This should help prevent mistakes in the future 😃

NoahGorny
NoahGorny approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's merge the fix and the tests together

@NoahGorny NoahGorny merged commit 7e79212 into Bash-it:master Jan 27, 2022
@gaelicWizard gaelicWizard deleted the lib/preexec branch January 27, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelicWizard @NoahGorny