-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added billing mode #266
added billing mode #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you specify the new billing mode you no longer should be sending the ProvisionedThroughput parameter. For maximum type safety we should make this optional and make the whole constructor private. Then we can add 2 new methods that instantiate a table with the different billing modes as well as a default for backwards compatibility in the companion. See AWS::EC2::EIP
as an example. I can code that up after I finish going through all the PRs.
Have added a conditional check and more tests to cover the conditional check scenarios. Take a look and see if this makes sens |
to get the BillingMode PAY_PER_REQUEST even better supported. Implemented the check (and tests) that ProvisionedThoughput is also not allowed in the GlobalSecondaryIndexes when PAY_PER_REQUEST is enabled.
Extended on [this PR](Bayer-Group#266) to get the BillingMode PAY_PER_REQUEST even better supported. Implemented the check (and tests) that ProvisionedThroughput is also not allowed in the GlobalSecondaryIndexes when PAY_PER_REQUEST is enabled.
Added option for specifying the billing mode which in turn provides on-demand read-write capacity
See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html#cfn-dynamodb-table-billingmode
read more in this blog https://aws.amazon.com/blogs/aws/amazon-dynamodb-on-demand-no-capacity-planning-and-pay-per-request-pricing/