Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added billing mode #266

Merged
merged 6 commits into from
Jan 16, 2019
Merged

added billing mode #266

merged 6 commits into from
Jan 16, 2019

Conversation

koshyvineet
Copy link
Contributor

Copy link
Collaborator

@tjcorr tjcorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you specify the new billing mode you no longer should be sending the ProvisionedThroughput parameter. For maximum type safety we should make this optional and make the whole constructor private. Then we can add 2 new methods that instantiate a table with the different billing modes as well as a default for backwards compatibility in the companion. See AWS::EC2::EIP as an example. I can code that up after I finish going through all the PRs.

@koshyvineet
Copy link
Contributor Author

If you specify the new billing mode you no longer should be sending the ProvisionedThroughput parameter. For maximum type safety we should make this optional and make the whole constructor private. Then we can add 2 new methods that instantiate a table with the different billing modes as well as a default for backwards compatibility in the companion. See AWS::EC2::EIP as an example. I can code that up after I finish going through all the PRs.

Have added a conditional check and more tests to cover the conditional check scenarios. Take a look and see if this makes sens

@tjcorr tjcorr merged commit b9b719f into Bayer-Group:master Jan 16, 2019
IvoNet pushed a commit to IvoNet/cloudformation-template-generator that referenced this pull request Jan 21, 2019
to get the BillingMode PAY_PER_REQUEST even better supported.
Implemented the check (and tests) that ProvisionedThoughput is also not allowed in the GlobalSecondaryIndexes
when PAY_PER_REQUEST is enabled.
IvoNet pushed a commit to IvoNet/cloudformation-template-generator that referenced this pull request Jan 21, 2019
Extended on [this PR](Bayer-Group#266)
to get the BillingMode PAY_PER_REQUEST even better supported.
Implemented the check (and tests) that ProvisionedThroughput is also not allowed in the GlobalSecondaryIndexes
when PAY_PER_REQUEST is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants