Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tasks): make it work on umbrella child apps #757

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Conversation

leandrocp
Copy link
Contributor

@leandrocp leandrocp commented Feb 12, 2025

It works and files are patched as expected but Igniter can't resolve the config files path correctly yet, so it does create new files in the child app at ./config and Igniter does solve config file paths properly.

A warning is displayed to guide users to manually move those files or the patches into the project root config files.

It works and files are patched as expected but Igniter can't resolve
the config files path correctly yet, so it does create new files
in the child app at ./config

A warning is displayed to guide users to manually move those files
or the patches into the project root config files.
@leandrocp leandrocp requested a review from APB9785 February 12, 2025 17:44
@leandrocp leandrocp changed the title chore(tasks): make it work on umbrella child apps (partially) chore(tasks): make it work on umbrella child apps Feb 12, 2025
@leandrocp leandrocp merged commit 80b7fc3 into main Feb 12, 2025
3 checks passed
@leandrocp leandrocp deleted the lp-tasks-umbrella branch February 12, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants