Add --endpoint option for beacon.gen.site
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrocp
requested changes
Feb 14, 2025
lib/mix/tasks/beacon.gen.site.ex
Outdated
| @@ -101,6 +104,7 @@ if Code.ensure_loaded?(Igniter) do | |||
|
|
|||
| port = Keyword.get_lazy(options, :port, fn -> Enum.random(4101..4999) end) | |||
| secure_port = Keyword.get_lazy(options, :secure_port, fn -> Enum.random(8444..8999) end) | |||
| site_endpoint = Keyword.get_lazy(options, :endpoint, fn -> site_endpoint_module!(igniter, site) end) | |||
There was a problem hiding this comment.
Values given from args are in binary so you need to convert to a proper module:
Suggested change
| site_endpoint = Keyword.get_lazy(options, :endpoint, fn -> site_endpoint_module!(igniter, site) end) | |
| site_endpoint = Keyword.get_lazy(options, :endpoint, fn -> site_endpoint_module!(igniter, site) end) | |
| site_endpoint = Module.concat([site_endpoint]) |
| @@ -33,6 +33,8 @@ defmodule Mix.Tasks.Beacon.Gen.Site.Docs do | |||
| * `--host` (optional) - If provided, site will be served on that host. | |||
| * `--port` (optional) - The port to use for http requests. Only needed when `--host` is provided. If no port is given, one will be chosen at random. | |||
| * `--secure-port` (optional) - The port to use for https requests. Only needed when `--host` is provided. If no port is given, one will be chosen at random. | |||
| * `--endpoint` (optional) - The name of the Endpoint Module for your site. If not provided, a default will be generated based on the `site`. | |||
There was a problem hiding this comment.
Depending on the name, Igniter will try to create files in a path that users may not expect. For eg:
--endpoint DockYardWeb.Endpoint
Creates the file lib/dock_yard_web/endpoint.ex
Which is expected because it follows the Phoenix convention. Are we just follow that pattern or find a way to overwrite the path name as well?
leandrocp
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #759