Support for Katana GF76-11UC, 17L2EMS1.108 #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms fan speed is reversed (more value in ec -> less fan speed). This commit adds a workaround for this problem without break of existing APIs.
|
You shouldn't use RPM values, this thing is broken by design. Technically, you can add RPM values and read them separately. This also will require separating %RPM and RPM addresses, which was broken when EC map was badly researched |
By default kernel triggers the setter on led_classdev_unregister which leads to keyboard brightness reset (the keyboard backlight turns off). This behavior may cause resets every system reboot. Also it's quite annoying in development.
|
As the driver with support for fan speed in sensors is out, I think this PR is obsolete. The only thing I want to keep is Fix keyboard brightness reset on module exit. commit because it is annoying to see light swithces for keyboard backlight when the driver exists. |
Alright, I cherry-picked it bfce260. And added a docs entry for Katana GF76 11UC |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Katana GF76-11UC (#138)
List of changes:
On tihs platform fan speed is reversed (more value in ec -> less fan speed). This PR adds a workaround for this problem without break of existing APIs.
A one problem keeps: In fact fan speed takes 2 bytes (for me, 0xc8 and 0xc9) but the module supports only one byte (0xc9).
On my laptop CPU fan speed is inversed so when fan gets slow it turns out to be (0x00 0xfa -> 0x00 0xff -> 0x01 0x08) Which may lead to EINVAL (when it reads 0x08 and compares it with maximum speed). But this is not critical because such a big value is reported for about 1 second and only when fan is about to stop and become 0x00 0x00.
By default kernel triggers the setter on led_classdev_unregister which
leads to keyboard brightness reset (the keyboard backlight turns off).
This behavior may cause resets every system reboot. Also it's quite
annoying in development.