Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new model: "1594EMS1" MSI Prestige 16 Studio A13VE #78

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

glpnk
Copy link
Contributor

@glpnk glpnk commented Aug 29, 2023

#77

Needs testing and review

@glpnk glpnk marked this pull request as ready for review September 9, 2023 01:19
@glpnk
Copy link
Contributor Author

glpnk commented Sep 9, 2023

@teackot ready to merge. Review here

UPD: what you think about hiding cpu/basic_fan_speed for unsupported models?

@teackot
Copy link
Collaborator

teackot commented Sep 9, 2023

UPD: what you think about hiding cpu/basic_fan_speed for unsupported models?

We should hide it. In fact we should hide any unsupported attributes in the cpu and gpu groups. I have created an issue to keep track of it earlier: #75

@teackot
Copy link
Collaborator

teackot commented Sep 9, 2023

Everything looks fine

@teackot teackot merged commit 84baf96 into BeardOverflow:main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants