Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cgenff toluene #228

Merged
merged 20 commits into from
Jan 12, 2023
Merged

Support cgenff toluene #228

merged 20 commits into from
Jan 12, 2023

Conversation

VOD555
Copy link
Contributor

@VOD555 VOD555 commented Jan 12, 2023

Fix #222 #223
Support cgenff toluene.

iorga and others added 20 commits December 4, 2022 19:32
* add toluene option for AMBER and OPLS-AA in forcefields.py

* add Gtol and pTW for the solvation free energy of a solute in toluene.

* Add TolueneSimulation for running equilibrium simulation for a solute in toluene.

* add toluene as options for equilibrium and fep simulations

* "[atomtypes]" in 1tol.itp are moved to ffnonbonded.itp and renamed to avoid conflict with atomtypes in solute parameters generated by GAFF

* add tests for OPLS-AA and AMBER toluene solvent

Co-authored-by: Shujie Fan <[email protected]>
@VOD555 VOD555 requested review from iorga and orbeckst January 12, 2023 21:02
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #228 (6f75dc5) into develop (9849104) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #228   +/-   ##
========================================
  Coverage    79.05%   79.05%           
========================================
  Files           12       12           
  Lines         1728     1728           
  Branches       271      271           
========================================
  Hits          1366     1366           
  Misses         277      277           
  Partials        85       85           
Impacted Files Coverage Δ
mdpow/forcefields.py 87.80% <ø> (ø)
mdpow/run.py 64.57% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@iorga iorga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @VOD555 !

@VOD555 VOD555 merged commit e5ce7af into develop Jan 12, 2023
@VOD555 VOD555 deleted the toluene_box branch January 12, 2023 21:48
@VOD555 VOD555 restored the toluene_box branch January 20, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add toluene as solvent
3 participants