-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup and support toluene in mdpow-solvationenergy
#230
Conversation
* add toluene option for AMBER and OPLS-AA in forcefields.py * add Gtol and pTW for the solvation free energy of a solute in toluene. * Add TolueneSimulation for running equilibrium simulation for a solute in toluene. * add toluene as options for equilibrium and fep simulations * "[atomtypes]" in 1tol.itp are moved to ffnonbonded.itp and renamed to avoid conflict with atomtypes in solute parameters generated by GAFF * add tests for OPLS-AA and AMBER toluene solvent Co-authored-by: Shujie Fan <[email protected]>
…nto toluene_box
…nto toluene_box
Codecov Report
@@ Coverage Diff @@
## develop #230 +/- ##
========================================
Coverage 79.05% 79.05%
========================================
Files 12 12
Lines 1728 1728
Branches 271 271
========================================
Hits 1366 1366
Misses 277 277
Partials 85 85 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@iorga I tested the scripts locally with S01 data. Can you pull and install the toluene_box branch to see whether it works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @VOD555 !
Fix #222
mdpow-solvationenergy