-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black formatting #269
Black formatting #269
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #269 +/- ##
========================================
Coverage 81.29% 81.29%
========================================
Files 15 15
Lines 1978 1978
Branches 297 297
========================================
Hits 1608 1608
Misses 278 278
Partials 92 92
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #271 — please
- blacken all code (in
mdpow
,mdpow/tests
, andscripts
) - add yourself to AUTHORS
- add an entry to CHANGES
Done, I also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looking good.
There are minor formatting changes for the CHANGES. You can just accept my "suggestions" from the comments.
My original plan was to squash-merge. However, if you're familiar with git
then you could rewrite the history of this branch into two commits:
- all black changes
- all other changes (AUTHORS, CHANGES, workflows, updated .git-blame-ignore-revs with the commit ID of (1))
Then I will be able to just merge without any need for any further changes.
Let me know if you want to rewrite the history. Otherwise I'll squash-merge after the code review suggestions are included and tests pass.
.git-blame-ignore-revs
Outdated
@@ -0,0 +1,4 @@ | |||
# Autoformat two files using `black` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding. I'll squah-merge and then rewrite this file afterwards with the proper commit id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Unless you rewrite the history yourself and add the proper commit ID of the single commit with all black-generated changes. See review comment.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm not confident I'll get that right to be honest with you! If it's OK, I'll leave it to you to change the hashes after merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will do
No functional changes.
- Add Alex to authors - Add `black` to changes
f1174c0
to
2ddf4cd
Compare
I rewrote the history. |
Alright, we're now using |
Use
black
to format two files, per this request.