-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compatibility with MDAnalysis 2.4 #36
Changes from 16 commits
38d33d6
c8b0c70
29ed5f0
10f0dc1
378d368
6f2eb4e
ac8aedf
80109b0
01b757f
7d3c2a5
7af70dd
8c1dc3b
8899c76
e9def9e
ebcbad9
8bb8e13
35c7a61
192d62d
1e50bf4
6e25161
fa47c3e
e53620b
d511a44
963c285
efee7e5
626144a
6bfed36
3bee6ca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,141 @@ | ||||||||
name: GH Actions CI | ||||||||
on: | ||||||||
push: | ||||||||
branches: | ||||||||
- master | ||||||||
- dev | ||||||||
pull_request: | ||||||||
branches: | ||||||||
- master | ||||||||
- dev | ||||||||
schedule: | ||||||||
- cron: "0 0 * * 0" | ||||||||
|
||||||||
concurrency: | ||||||||
group: ${{ github.ref }}-${{ github.head_ref }}-${{ github.workflow }} | ||||||||
cancel-in-progress: true | ||||||||
|
||||||||
defaults: | ||||||||
run: | ||||||||
shell: bash -l {0} | ||||||||
|
||||||||
jobs: | ||||||||
environment-config: | ||||||||
runs-on: ubuntu-latest | ||||||||
outputs: | ||||||||
stable-python-version: ${{ steps.get_python_version.outputs.python-version }} | ||||||||
steps: | ||||||||
- uses: actions/checkout@v3 | ||||||||
|
||||||||
- id: get-python-version | ||||||||
uses: MDAnalysis/get-latest-python-version@main | ||||||||
with: | ||||||||
last-n-minor-release: 1 | ||||||||
|
||||||||
main-tests: | ||||||||
if: "github.repository == 'Becksteinlab/propkatraj'" | ||||||||
runs-on: ${{ matrix.os }} | ||||||||
strategy: | ||||||||
fail-fast: false | ||||||||
matrix: | ||||||||
os: [macOS-latest, ubuntu-latest, windows-latest] | ||||||||
python-version: ["3.8", "3.9", "3.10", "3.11"] | ||||||||
mdanalysis-version: ["latest", "develop"] | ||||||||
|
||||||||
steps: | ||||||||
- uses: actions/checkout@v3 | ||||||||
- name: Build information | ||||||||
run: | | ||||||||
uname -a | ||||||||
df -h | ||||||||
ulimit -a | ||||||||
|
||||||||
- name: Install conda dependencies | ||||||||
uses: conda-incubator/setup-miniconda@v2 | ||||||||
with: | ||||||||
python-version: ${{ matrix.python-version }} | ||||||||
environment-file: devtools/environment.yml | ||||||||
add-pip-as-python-dependency: true | ||||||||
architecture: x64 | ||||||||
|
||||||||
miniforge-variant: Mambaforge | ||||||||
use-mamba: true | ||||||||
channels: conda-forge, defaults | ||||||||
|
||||||||
activate-environment: propkatraj-test | ||||||||
auto-update-conda: true | ||||||||
auto-activate-base: false | ||||||||
show-channel-urls: true | ||||||||
|
||||||||
- name: Install MDAnalysis version | ||||||||
uses: MDAnalysis/install-mdanalysis@main | ||||||||
with: | ||||||||
version: ${{ matrix.mdanalysis-version }} | ||||||||
install-tests: true | ||||||||
installer: mamba | ||||||||
shell: bash -l {0} | ||||||||
|
||||||||
- name: Install package | ||||||||
run: | | ||||||||
python --version | ||||||||
python -m pip install . --no-deps | ||||||||
- name: Python information | ||||||||
run: | | ||||||||
which python | ||||||||
which pip | ||||||||
pip list | ||||||||
conda info | ||||||||
conda list | ||||||||
- name: Run tests | ||||||||
run: | | ||||||||
pytest -v --color=yes propkatraj/tests/ | ||||||||
|
||||||||
|
||||||||
pylint_check: | ||||||||
if: "github.repository == 'Becksteinlab/propkatraj'" | ||||||||
needs: environment-config | ||||||||
runs-on: ubuntu-latest | ||||||||
|
||||||||
steps: | ||||||||
- uses: actions/checkout@v3 | ||||||||
|
||||||||
- name: Set up Python | ||||||||
uses: actions/setup-python@v4 | ||||||||
with: | ||||||||
python-version: ${{ needs.environment-config.outputs.stable-python-version }} | ||||||||
|
||||||||
- name: Install Pylint | ||||||||
run: | | ||||||||
which pip | ||||||||
which python | ||||||||
pip install pylint MDAnalysis>=2.0.0 | ||||||||
- name: Run Pylint | ||||||||
env: | ||||||||
PYLINTRC: .pylintrc | ||||||||
run: | | ||||||||
pylint propkatraj | ||||||||
pypi_check: | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
as above, empty line consistency There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's some empty line consistency issues all over this yaml 🤣 it's not technically incorrect so I won't block over it, but I don't know how I'm the only one feeling anxious looking at the formatting.. |
||||||||
if: "github.repository == 'Becksteinlab/propkatraj'" | ||||||||
needs: environment-config | ||||||||
runs-on: ubuntu-latest | ||||||||
|
||||||||
steps: | ||||||||
- uses: actions/checkout@v3 | ||||||||
|
||||||||
- name: Set up Python ${{ needs.environment-config.outputs.stable-python-version }} | ||||||||
uses: actions/setup-python@v4 | ||||||||
with: | ||||||||
python-version: ${{ needs.environment-config.outputs.stable-python-version }} | ||||||||
|
||||||||
- name: Install dependencies | ||||||||
run: | | ||||||||
pip install setuptools cython numpy twine | ||||||||
- name: Build package | ||||||||
run: | | ||||||||
python setup.py sdist | ||||||||
- name: Check package build | ||||||||
run: | | ||||||||
DISTRIBUTION=$(ls -t1 dist/propkatraj-*.tar.gz | head -n 1) | ||||||||
test -n "${DISTRIBUTION}" || { echo "no distribution dist/propkatraj-*.tar.gz found"; exit 1; } | ||||||||
echo "twine check $DISTRIBUTION" | ||||||||
twine check $DISTRIBUTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a consistency thing