Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAGS: Rust-g #10455

Merged
merged 8 commits into from
Feb 16, 2024
Merged

GAGS: Rust-g #10455

merged 8 commits into from
Feb 16, 2024

Conversation

itsmeow
Copy link
Member

@itsmeow itsmeow commented Jan 11, 2024

About The Pull Request

Implements Rust-G GAGS and bumps to rust-g 3.1.2. 3.1.2 also optimizes spritesheet generation a little bit and fixes subtract blending.

GAGS icons now take 1ms per icon rather than 250ms (250x speed increase), making GAGS actually usable. Works by outputting the result to a DMI in tmp and assigns it to icon.

This version of GAGS does not support:

  • The color_matrix layer type
  • The or blending mode
  • BYOND Parity on obscure operations with multiple icon_states at the same time (animated sprites, unscoped/stateless icons, mixed-dirs aka overlaying icons with different dir amounts)

We do not currently use any of the above features, and the old code is left intact for use in 'live' icon generation, so I consider this a fair trade-off for an underutilized system that is incredibly slow.

Why It's Good For The Game

Performance improvement

Testing Photographs and Procedure

Screenshots&Videos

image

Changelog

🆑
code: Optimized GAGS via Rust-g. It is now 250x faster.
/:cl:

@itsmeow itsmeow requested a review from Crossedfall as a code owner January 11, 2024 21:58
@github-actions github-actions bot added the Tools label Jan 12, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Crossedfall Crossedfall added this pull request to the merge queue Feb 16, 2024
Merged via the queue into BeeStation:master with commit 5ebffa1 Feb 16, 2024
8 checks passed
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
* GAGS Rustg

* Bump rust-g to 3.1.2

* Move to tmp

* Copy json configs into tests

* Fix tests

* Begone tabs

* Optimize greyscale_layer init
DrDuckedGoose pushed a commit to DrDuckedGoose/BeeStation-Hornet that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants