Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Missile/Torpedo durability buffs #2762

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SerynEngi
Copy link
Contributor

@SerynEngi SerynEngi commented Feb 9, 2025

About The Pull Request

This pull request creates a subtype of all missiles and torpedoes for AI usage and then buffs the durability player-only variants by 200%

Why It's Good For The Game

Missiles and torpedoes should be effective. Here, we have a single player ship sometimes fighting huge fleets. This should help those weapons actually be effective when facing more than 2 or 3 enemies.

Changelog

🆑
add: Added variants of torpedos and missiles for AI usage
balance: Buffed the durability of player ship missiles and torps
/:cl:

missiles too.
@SerynEngi
Copy link
Contributor Author

SerynEngi commented Feb 9, 2025

This was balanced for playership + fighters VS fleet, and can be tuned up or down fairly easily to desired outcome. The goal here is that it isnt every missile or torp that makes it through, but is instead that some missiles make it more than 3 tiles away from mainship or fightership before getting annihilated when facing a fleet.

I am aware that this may create some interesting scenarios in PVP, however missiles and torps are very expensive to build and take substantially more time to produce. In this scenario, ideally it creates a choice between effective missiles at several times the cost, or fast and heavy hitting NAC shells.

@SerynEngi SerynEngi added Overmap This issue or PR is related to overmap interactions Munitions Issues and pull requests related to munitions. labels Feb 13, 2025
Ya know, buffed torps against the PVP syndicate ship would probably suck
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some instances of Hellfire and Disruptor torpedoes you've missed in this. Otherwise it looks good

@SerynEngi
Copy link
Contributor Author

So, I may have forgotten, in my haste, that hellfire and disruptor torps already have a separate subtype that players use, and unlike every other torpedo and missile I instead buffed the previously existing player variant. Reverted to the second commit.

Copy link
Contributor

@DeltaFire15 DeltaFire15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving decisions on whether this is good to higher dev staff (because I still believe torp is pretty good if not fired straight into the foe's barrage),

however code-wise please replace any /nerfed with /ai (or /ai_version if you want to be verbose), because that is what they are.
(plus the stuff bokkie pinged you with)

@Bokkiewokkie Bokkiewokkie added Needs Test Merge This PR is ready for test merge during a test to determine effectiveness. and removed Active Test Merge labels Feb 15, 2025
@Bokkiewokkie Bokkiewokkie added Active Test Merge and removed Needs Test Merge This PR is ready for test merge during a test to determine effectiveness. labels Feb 21, 2025
@DeltaFire15 DeltaFire15 dismissed their stale review February 25, 2025 14:57

changes addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Balance/Rebalance Munitions Issues and pull requests related to munitions. Overmap This issue or PR is related to overmap interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants