Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blur & Noise in Blur/Grain & Denoise not applied globally with the global spot method #7226

Open
Lawrence37 opened this issue Oct 21, 2024 · 1 comment · May be fixed by #7274
Open

Blur & Noise in Blur/Grain & Denoise not applied globally with the global spot method #7226

Lawrence37 opened this issue Oct 21, 2024 · 1 comment · May be fixed by #7274
Labels
tool: selective editing type: bug Something is not doing what it's supposed to be doing
Milestone
v5.12

Comments

@Lawrence37
Copy link
Collaborator

Short description
The blur, noise, and film grain in Blur/Grain & Denoise do not get applied to the whole image when the spot method is set to global.

Steps to reproduce

  1. Enable Selective Editing and add a spot.
  2. Change the Spot method to Global.
  3. Add the Blur/Grain & Denoise tool.
  4. Play around with the radius, noise, and film grain settings.

Expected behavior
The blur, noise, and film grain should be applied uniformly to the entire image. Instead, it is applied to regions similar to the color below the spot, as if the scope is still active.

Additional information
Using the other spot methods, the scope in the tool becomes available. Changing the scope, then changing the spot method back to global shows that the scope affects the regions affected by the tool.
@Lawrence37 Lawrence37 added type: bug Something is not doing what it's supposed to be doing tool: selective editing labels Oct 21, 2024
@Lawrence37 Lawrence37 added this to the v5.12 milestone Oct 21, 2024
@Desmis
Copy link
Collaborator

Desmis commented Oct 21, 2024

@Lawrence37

Well spotted, it's just an oversight. I'll add that to the iplocallab.cc code in : ImProcFunctions::BlurNoise_Local
const float reducdE = calcreducdE(dE, maxdE, mindE, maxdElim, mindElim, lp.iterat, limscope, lp.sensbn);

            Replace by:
            float reducdE = calcreducdE(dE, maxdE, mindE, maxdElim, mindElim, lp.iterat, limscope, lp.sensbn);
            if(lp.fullim == 3 ) {//disabled scope
                reducdE = 1.f;
            }

Jacques

@Desmis Desmis mentioned this issue Oct 28, 2024
Merged
@Lawrence37 Lawrence37 linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tool: selective editing type: bug Something is not doing what it's supposed to be doing
Projects
None yet
Milestone
v5.12
Development

Successfully merging a pull request may close this issue.

Fix for Blur/Grain & Denoise in global mode Beep6581/RawTherapee
2 participants
@Desmis @Lawrence37