Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFTW blur radius fix #7235

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

Lawrence37
Copy link
Collaborator

Closes #7225.

Fix the formula, adapt old pp3s, and change the maximum blur radius
where applicable.
@Desmis
Copy link
Collaborator

Desmis commented Oct 28, 2024

@Lawrence37

This PR also fix #7226.
Change in iplocallab.cc = > ImProcFunctions::BlurNoise_Local

@Desmis
Copy link
Collaborator

Desmis commented Oct 28, 2024

@Lawrence37

It's good for me.

I will be away from home for 15 days or 3 weeks. But I think I can be reached.

@Lawrence37
Copy link
Collaborator Author

Thanks for reviewing @Desmis.

@Desmis
Copy link
Collaborator

Desmis commented Oct 29, 2024

It is ok for me for this part (fftw).

In my proposition (fixbug-blur), there was also the solution to issue 7226, as well as a notable improvement for the user when he wants to blur a background. I changed the way the "Recovery based on luminance mask" function works. Now this function works with "Gaussian blur (noise and grain) , Median, and Guided Filter instead of only Guide Filter.

I assume that these proposals will be dealt with later, separately from this PR.

@Lawrence37
Copy link
Collaborator Author

Since this pull request also handles the pp3 compatibility, I will merge it and see if the other fixes and improvements can be incorporated directly from your branch @Desmis.

@Lawrence37 Lawrence37 merged commit 98136d3 into Beep6581:dev Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selective Editing blur radius different in preview
2 participants