update Pillow to >=10.0.0 and update get_text_height api #323
Conversation
There was a problem hiding this comment.
This change is necessary to fix a local installation from the source code which by default gets Pillow>=10.0.0.
getsize was deprecated in Pillow 9 and removed in Pillow 10. Since Pillow 8 the alternative getbbox exists.
See https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html#font-size-and-offset-methods.
| @@ -145,4 +145,5 @@ def get_text_height(image_font: ImageFont, text: str) -> int: | |||
| """ | |||
| Get the width of a string when rendered with a given font | |||
There was a problem hiding this comment.
| Get the width of a string when rendered with a given font | |
| Get the height of a string when rendered with a given font |
There was a problem hiding this comment.
This is an unrelated fix of a copy+paste documentation bug.
There was a problem hiding this comment.
Pull request #334 fixes this comment.
| @@ -145,4 +145,5 @@ def get_text_height(image_font: ImageFont, text: str) -> int: | |||
| """ | |||
| Get the width of a string when rendered with a given font | |||
| """ | |||
| return image_font.getsize(text)[1] | |||
| left, top, right, bottom = image_font.getbbox(text) | |||
| return bottom - top | |||
There was a problem hiding this comment.
In my local testing with Pillow v10.2, this produces different results than before. Comparing the output of getsize and getbbox with Pillow 9.5.0 (which has both APIs):
trdg -c 5
...
text "a" get_bbox (0, 16, 16, 32) get_size (16, 32)
So counter-intuitively, get_size was returning the value of the bottom of the bounding box rather than bottom - top.
There was a problem hiding this comment.
There is a working version of the fix at robertknight@5abfc4f.
There was a problem hiding this comment.
Hm, yes, you are right. Here is a similar fix.
The official Pillow documentation suggests the fix with bottom - top, but that would indeed give different results.
There was a problem hiding this comment.
The pull request needs the change suggested by @robertknight. I tested the modifications with Python 3.7, and with that change all tests pass.
| left, top, right, bottom = image_font.getbbox(text) | ||
| return bottom - top |
There was a problem hiding this comment.
| left, top, right, bottom = image_font.getbbox(text) | |
| return bottom - top | |
| left, top, right, bottom = image_font.getbbox(text) | |
| return bottom |
There was a problem hiding this comment.
Test results with original code:
Ran 63 tests in 161.579s
OK
Test result with the original pull request (return bottom - top):
Ran 63 tests in 159.993s
FAILED (failures=23)
Test result with the fix suggested by @robertknight (return bottom):
Ran 63 tests in 161.534s
OK
|
@Belval, please merge with the suggested change. |
|
Merged a bit too fast, master with latest commit has suggested changes. Thank you for your contributions |
update Pillow to >=10.0.0 and update get_text_height api
completely
#315
@Belval