Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The number of threads does not change through the command line #157

Closed
Renemen64 opened this issue Aug 17, 2018 · 11 comments
Closed

The number of threads does not change through the command line #157

Renemen64 opened this issue Aug 17, 2018 · 11 comments

Comments

@Renemen64
Copy link

The new version of the program stopped working with the command line parameter -t, --threads=N
in version 1.5.2 - it works
in the newer versions no longer works

@Bendr0id
Copy link
Owner

Which platform?
1.6.5 or 1.7.0_beta1?

@Renemen64
Copy link
Author

Ah, sorry foregot to say:
Windows x64, gcc version
last chacked in 1.6.5

@Renemen64
Copy link
Author

just checked version 1.7.0 - same problem
I'm using the Windows scheduler, so it's easier for me to set the parameters in the command line than in the configuration file.

@Bendr0id
Copy link
Owner

Ok. So there is no config file at all? Because it could overrule when there is one..

@Renemen64
Copy link
Author

The configuration file is there, but I use it as a template. In the command line, I change basically the number of threads and affinity to CPU.

@Bendr0id
Copy link
Owner

Ok check if threads is set there.. if so, remove it

@Renemen64
Copy link
Author

OK I understood. If I delete the "threads" parameter in the configuration file, then I can switch the number of threads.
But, as I said in earlier versions, the command-line option had a higher priority, and this is more logical.

@Bendr0id
Copy link
Owner

I agree it is. But i can't find code where it was working that way in the past.. I'll think about how i can change the behavior.

@Renemen64
Copy link
Author

Any way, thanks for a tip. I will use this method as woraround.

@Bendr0id
Copy link
Owner

Do you build on your own? If so, please check latest 1.7.0 branch

@Bendr0id
Copy link
Owner

Fixed in master. Will be in release 1.7.0

@Bendr0id Bendr0id mentioned this issue Aug 26, 2018
Bendr0id added a commit that referenced this issue Aug 26, 2018
# 1.7.0
- First official Release of XMRigCC-amd #33 #3
- Full integration of xmrigCC-amd into XMRigCCServer/Dashboard with GPUInfo / remote logging
- Config property to enable/disable config upload on startup (--cc-upload-config-on-startup) #80
- Refactoring of remote logging feature: #143
    - Only deltas will be send to the XMRigCCServer
    - Fetching miner log on dashboard upon need
    - Maximum lines of log history kept per miner can be configured on XMRigCCServer 
- Fix correct hugepages status on Dashboard
- Fix cpu affinity for single thread usage
- Add all needed security infos to XMRigCCServer logging to harden the server (f.e. fail2ban)
- Fix commandline params overwrite config.json #157
- Fix building miner with API support #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants