Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CI improvements: updated versions and better reporting #55

Merged
merged 5 commits into from
Dec 30, 2023

Conversation

BenjaminSchubert
Copy link
Owner

@BenjaminSchubert BenjaminSchubert commented Dec 29, 2023

  • Update all the workflows to their latest major version
  • Simplify handling of coverage artifacts
  • generate junit reports and display a summary
  • Generate junit and coverage report also on failure

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ce462b) 87.50% compared to head (d15cde9) 87.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   87.50%   87.54%   +0.03%     
==========================================
  Files          51       53       +2     
  Lines        2305     2312       +7     
  Branches      297      297              
==========================================
+ Hits         2017     2024       +7     
  Misses        226      226              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Now that the action suport a pattern for artifact names, we can more
easily download them
@BenjaminSchubert BenjaminSchubert force-pushed the bschubert/update-ci branch 2 times, most recently from 5db740c to ad27fda Compare December 29, 2023 23:09
@BenjaminSchubert BenjaminSchubert force-pushed the bschubert/update-ci branch 5 times, most recently from edef322 to 3f2d343 Compare December 30, 2023 12:28
@BenjaminSchubert BenjaminSchubert marked this pull request as ready for review December 30, 2023 12:44
We will want to compiel coverage from multiple OSs, which we do not
handle normally otherwise. As such, let's just use coverage, it's going
to be faster too
@BenjaminSchubert BenjaminSchubert merged commit 4579155 into main Dec 30, 2023
20 checks passed
@BenjaminSchubert BenjaminSchubert deleted the bschubert/update-ci branch December 30, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant