Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dimming of ignores skip meta and ignores #924

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Make dimming of ignores skip meta and ignores #924

merged 1 commit into from
Jan 5, 2021

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Jan 3, 2021

We were not allowing the forwardSexpr of the token cursor used for dimming ignores to skip past metadata.

Fixes #908

There are still issues with the stacking of ignores in the presence of metadata, but this at least takes care of the reported case.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

@PEZ
Copy link
Collaborator Author

PEZ commented Jan 5, 2021

Any particular reason that this didn't make the .146 cut, @bpringe ?

@bpringe
Copy link
Member

bpringe commented Jan 5, 2021

I guess I didn't realize it was complete.

@bpringe bpringe merged commit 3107d9c into dev Jan 5, 2021
@bpringe bpringe deleted the 908-dim-meta branch January 5, 2021 17:43
@PEZ
Copy link
Collaborator Author

PEZ commented Jan 5, 2021

Too tiny fix. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants