Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more pokemon! #1

Open
BhavyaCodes opened this issue Oct 1, 2020 · 17 comments
Open

Add more pokemon! #1

BhavyaCodes opened this issue Oct 1, 2020 · 17 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@BhavyaCodes
Copy link
Owner

BhavyaCodes commented Oct 1, 2020

Go to pokeapi website, Right below the Try It now heading you will find an api endpoint that you can try. replace ditto with your favorite pokemon, then edit /src/pokemon.json file. Add an object with the pokemon details in the array, be sure to get the id from pokeapi, you may use any imageurl, formatting should be exactly like the 2 original examples on top.

EDIT: please do not add more than 5 pokemon within a pull request! Current pull requests with upto 50 pokemon will be merged but more than that I'm sorry, I can't merge that, we don't have any system for pagination yet, also the data is saved in just a json file. It won't be efficient to import 1000 pokemon from json then sort them and render them on the DOM. This will also affect the search bar performance a lot

@BhavyaCodes BhavyaCodes added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 1, 2020
@jakubkoje
Copy link
Contributor

I'm gonna look at it!

@zatch3301
Copy link

it's fun adding pokemon ^^

@redrails
Copy link
Contributor

redrails commented Oct 1, 2020

#6 :)

@jakubkoje jakubkoje mentioned this issue Oct 1, 2020
@ghost
Copy link

ghost commented Oct 1, 2020

Why add Pokemon manually, when you can actually use the provided API to get all the data you want using fetch?

fetch(`https://pokeapi.co/api/v2/pokemon/${pokemonName}`)
  .then(response => response.json())
  .then(data => {
    // use pokemon data to display it
  });

@RidhikGovind
Copy link
Contributor

Why add Pokemon manually, when you can actually use the provided API to get all the data you want using fetch?

fetch(`https://pokeapi.co/api/v2/pokemon/${pokemonName}`)
  .then(response => response.json())
  .then(data => {
    // use pokemon data to display it
  });

This is a great way to do things

@BhavyaCodes
Copy link
Owner Author

hey, thanks for the suggestions but this project is mainly focused at beginners so they may get some practice with contributing to open source. I have already made a similar app that uses fetch, you can check it here https://pokemon-alpha.vercel.app/

@vatsalsharma376
Copy link
Contributor

#10 Added one more

@zatch3301
Copy link

zatch3301 commented Oct 1, 2020

@Juggernaut9 I added 40 Pokemon please merge it :)

@imabhinavagarwal
Copy link
Contributor

I m gonna try this. Seems fun

@WulfPlasma
Copy link
Contributor

WulfPlasma commented Oct 2, 2020

@Juggernaut9 Can I work on and contribute to this?

@WulfPlasma
Copy link
Contributor

@Juggernaut9 already added some if you want to merge. #46

@krishnasreekoganti
Copy link

@Juggernaut9 can I contribute to this?

@BhavyaCodes
Copy link
Owner Author

yes you can @krishnasreekoganti

@krishnasreekoganti
Copy link

I raised a PR for new Pokemon @Juggernaut9 can you please review

@daksha-aeer
Copy link

daksha-aeer commented Oct 30, 2020

@Juggernaut9 please accept my PRs for hacktoberfest
#67
#68
#69
#70

@MeetPatel41011
Copy link

Please accept my PRs for Hacktoberfest...!!

@Maria-Papa
Copy link
Contributor

Hey @BhavyaCodes!!

I added 5 Pokémon for Hacktoberfest, but Vercel build failed.
I can't see what's wrong with it, please tell me if anything needs fixing 😄!

PR: #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests