Added complete Pokémon data (Gen8 through 1) #40
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains complete Pokémon data for this project. And yes, its compatible with a small change(s).
Things to note:
I believe the sprite URLs can be improved by not putting the image links in the data file. Just a simple template literal / string join.
I haven't looked into code much, so I kept it like that.
New properties can be used to make it more better, like adding page for every mon! And of course, rendered dynamically.
EDIT: there was a typo in script, URLs are broken. Fixed