Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added complete Pokémon data (Gen8 through 1) #40

Closed
wants to merge 2 commits into from
Closed

Added complete Pokémon data (Gen8 through 1) #40

wants to merge 2 commits into from

Conversation

DjDeveloperr
Copy link

@DjDeveloperr DjDeveloperr commented Oct 2, 2020

This PR contains complete Pokémon data for this project. And yes, its compatible with a small change(s).
Things to note:

  • Weight unit may be different from the current one being used
  • New properties added: color, height, abilities, evolutions, baseStats, eggGroups and some more sprite resources (front, front shiny, back, back shiny).

I believe the sprite URLs can be improved by not putting the image links in the data file. Just a simple template literal / string join.
I haven't looked into code much, so I kept it like that.
New properties can be used to make it more better, like adding page for every mon! And of course, rendered dynamically.

EDIT: there was a typo in script, URLs are broken. Fixed

@vercel
Copy link

vercel bot commented Oct 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/juggernaut9/pokemon-hacktoberfest/51z1bmbpl
✅ Preview: https://pokemon-hacktoberfest-git-fork-djdeveloperr-patch-1.juggernaut9.vercel.app

@BhavyaCodes
Copy link
Owner

We can't handle so many pokemon, sorry. Please read #1

@DjDeveloperr
Copy link
Author

Alright. But what about pagination? That can be done pretty easily. Haven't looked much into the code though.
And there's no other efficient way to store Pokémon data in my opinion, JSON has been working good for me since ages.
We can decrease load on client side by turning it into an API which is paginated.
And thanks for that label :3

@DjDeveloperr DjDeveloperr deleted the patch-1 branch September 12, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants