@lsetiawan suggestions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haha thanks 😅. I do some web design on the side. 😄 |
lsetiawan
reviewed
Jul 5, 2017
| @@ -10,7 +10,7 @@ | |||
| -webkit-animation-delay: 0.15s; | |||
| animation-delay: 0.15s; | |||
| z-index: 20; | |||
| background-color: $masthead-background-color; | |||
| background-color: #5E5C57; | |||
There was a problem hiding this comment.
I'm surprised you didn't change this in https://github.com/BiG-CZ/notebook_data_demo/blob/master/webpage/jupyter_notebook_jekyll_theme/_sass/_variables.scss#L64
lsetiawan
reviewed
Jul 5, 2017
| @@ -175,7 +175,7 @@ | |||
| .greedy-nav { | |||
| position: relative; | |||
| min-width: 250px; | |||
| background-color: $greedy-nav-background-color; | |||
| background-color: #5E5C57; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I kind of wanted to preserve the original variables, but with git that does not really seem to be relevant...
lsetiawan
reviewed
Jul 5, 2017
lsetiawan
approved these changes
Jul 5, 2017
|
Thanks! Please merge as you two see fit. I'll comment on the background color choices (#3) later, likely not today. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses all @lsetiawan suggestions but #3 (comment), which is pending @emiliom opinion.
@lsetiawan you have quite a talent for
css! The page looks much better now.