Add support for heart languages

[mXaln]

This change is 

[AnonymousWalker]

if I remember correctly, the purpose of using the cache was to:

1. improve performance for page-load (GLs only)
2. avoid giving false positive - when the user click on something and then nothing is available

Maybe this could satisfy the first purpose which does not affect performance significantly. We need to verify this on dev after merging

Reviewed all commit messages.
Reviewable status: 0 of 19 files reviewed, 3 unresolved discussions (waiting on @mXaln)

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/di/DIModule.kt line 5 at r1 (raw file):

import org.bibletranslationtools.fetcher.config.DevEnvironmentConfig
import org.bibletranslationtools.fetcher.config.EnvironmentConfig
import org.bibletranslationtools.fetcher.impl.repository.*

please keep the import style consistent with how it was, this is easy to miss.

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/usecase/FetchProductViewData.kt line 25 at r1 (raw file):

                } else {
                    listOf("mp3", "wav")
                }

Originally, we were using enums to avoid hard-coded strings like these. Could we keep that practice?

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/web/controllers/BookController.kt line 81 at r1 (raw file):

            "fileTypesNavTitle" to product.titleKey,
            "fileTypesNavUrl" to "/$GL_ROUTE/${params.languageCode}",
            "booksNavUrl" to "javascript:void(0)"

this feels wrong to use here

[mXaln]

Reviewable status: 0 of 22 files reviewed, 3 unresolved discussions (waiting on @AnonymousWalker)

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/di/DIModule.kt line 5 at r1 (raw file):

Previously, AnonymousWalker (Tony) wrote…

please keep the import style consistent with how it was, this is easy to miss.

yeah, my IDE does that. Changed manually.

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/usecase/FetchProductViewData.kt line 25 at r1 (raw file):

Previously, AnonymousWalker (Tony) wrote…

Originally, we were using enums to avoid hard-coded strings like these. Could we keep that practice?

I was following the practice that was already in the code, like in the FetchBookViewData. Changed wherever I found it.

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/web/controllers/BookController.kt line 81 at r1 (raw file):

Previously, AnonymousWalker (Tony) wrote…

this feels wrong to use here

Well it's just another type of url. Yeah, it looks like js code, but that's necessary to have it here. Could you suggest something different?

[AnonymousWalker]

Reviewable status: 0 of 22 files reviewed, all discussions resolved

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/web/controllers/BookController.kt line 81 at r1 (raw file):

Previously, mXaln (Maxim) wrote…

Well it's just another type of url. Yeah, it looks like js code, but that's necessary to have it here. Could you suggest something different?

Yes, #196

[mXaln]

Reviewable status: 0 of 22 files reviewed, all discussions resolved (waiting on @AnonymousWalker)

---

fetcher-web/src/main/kotlin/org/bibletranslationtools/fetcher/web/controllers/BookController.kt line 81 at r1 (raw file):

Previously, AnonymousWalker (Tony) wrote…

Yes, #196

ok, that works!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud