-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport TypeAlias for py3.9 compat #1
Conversation
…ler, faster solution which only works for positive numbers. our inputs are generated by a linspace between two positive numbers, so we should be fine.
…e Elucidating paper arXiv:2206.00364 section C.3.4 "practical challenge" 3)
…rXiv:2206.00364 C.3.4), we don't want to generate an out-of-range sigma. make this optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see commentary here: invoke-ai/InvokeAI#302 (comment)
@Birch-san the lstein repo isn't working because of this. invoke-ai/InvokeAI#335 |
@Birch-san yesterday somebody downgraded the lstein mac environment to python 3.9, that's why it crashes now. This pull request makes this repo work with 3.9. I'm not sure if we will leave it at 3.9. They are discussing it here. |
I would note that this change is compatible with 3.9 and 3.10, so if this change is merged, you can use whichever version you please |
thanks! I'll integrate this. I'll also rebase onto latest (Katherine added a trivial optimization crowsonkb@4567328). I think I can simplify Unrelated to MPS, but the following two points pertain to the patches I've made for getting good results at low sample steps (e.g. 7 or 8)… I think I'll delete the likewise I'll delete the |
oh, so, we don't need to force python 3.9 users to install typing-extensions. I can just delete
so I think what I'll do is delete the offending code instead of integrating this PR, if that's okay with you? |
sgtm, the easiest way to fix code is delete code! |
thanks 🙂 I've now force-pushed a simpler branch to this removes the anybody who's currently got my branch checked out, will not be able to pull because I force-pushed a new history. to get yourself up-to-date, cd into the k-diffusion repository (e.g. git fetch origin mps
git reset --hard origin/mps |
No description provided.