Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create, update and/or make accessible article share links across all themes #4353

Closed
5 tasks done
StephDriver opened this issue Aug 9, 2024 · 4 comments · Fixed by #4355
Closed
5 tasks done

Create, update and/or make accessible article share links across all themes #4353

StephDriver opened this issue Aug 9, 2024 · 4 comments · Fixed by #4355
Assignees
Labels
a11y Issues that relate to acessibility

Comments

@StephDriver
Copy link
Contributor

StephDriver commented Aug 9, 2024

This issue combines the following three related issues into one piece of work.

The plan is to:

  • update the share links on the OLH theme to
  • Update the Material and Clean themes to match this update, tweaking it to fit their styles.
  • update Twitter to X within these share buttons
@StephDriver StephDriver added the a11y Issues that relate to acessibility label Aug 9, 2024
@StephDriver StephDriver self-assigned this Aug 9, 2024
@StephDriver
Copy link
Contributor Author

  • Aria labels for these lines had already updated on master since original 3933 issue,

@StephDriver
Copy link
Contributor Author

StephDriver commented Aug 9, 2024

Target for divs to align - see difference in #4340
image

for future ref, this was down to 'columns' class being left off the div which contained the row (the data-sticky).

@StephDriver
Copy link
Contributor Author

Since Twitter updated to X some time ago now, I'm also updating this twitter link to an X link.

@StephDriver
Copy link
Contributor Author

On Clean there aren't usually any buttons, which with social media icons makes the target too small for WCAG requirements, therefore I've added in a 'social-share-btn' class that gives a 'clean' 1px outline to these social sharing buttons.

image image

StephDriver added a commit that referenced this issue Aug 9, 2024
StephDriver added a commit that referenced this issue Aug 16, 2024
ajrbyers pushed a commit that referenced this issue Aug 29, 2024
ajrbyers pushed a commit that referenced this issue Aug 29, 2024
ajrbyers pushed a commit that referenced this issue Sep 11, 2024
ajrbyers pushed a commit that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant