Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4353 article page sharelinks a11y update #4355

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

StephDriver
Copy link
Contributor

Updated the share links across all themes for a11y.

  • OLH - tab order of share bar now matches visual order, and a small alignment fix.
  • Clean - now has share links
  • All themes: now have X instead of Twitter (and updates to css to make X in black instead of the blue bird).

NB the share links for Clean are buttons because of the need to meet WCAG minimum target size. More comments on this with screenshots on issue itself.

Closes #4353

which encompassed these, so it also:

Closes #3933
Closes #4340
Closes #1863

@StephDriver StephDriver force-pushed the 4353-article-page-sharelinks-a11y-update branch from e457555 to 1a037ac Compare August 16, 2024 13:44
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StephDriver, a small comment on the use of !important and how it might impact theme styling overrides.

Comment on lines 587 to 593
color: var(--twitter-hover) !important;
}

.twitter-bg:hover {
background-color: var(--twitter-hover);
color: var(--twitter) !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are adding explicit !important colours to the 𝕏 button we should probably do the same for other ones. If not, we will introduce inconsistency wherever someone has overriden btn colours.

e.g see https://www.comicsgrid.com/article/id/15400/

Alternatively, do not use the !important property, though I bet you are using because the changes wouldn't take effect on the base theme styling otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, they wouldn't work without !important and very good point, about consistency too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hover.mov

While updating, I also realised that the X button inverting on hover was different to the other two buttons - their hover action was a very very subtle change of colour. So I updated all three to the invert behaviour.

mauromsl

This comment was marked as duplicate.

@mauromsl mauromsl assigned StephDriver and unassigned mauromsl Aug 22, 2024
@StephDriver StephDriver requested a review from mauromsl August 23, 2024 09:26
@StephDriver StephDriver assigned mauromsl and unassigned StephDriver Aug 23, 2024
@StephDriver StephDriver requested a review from joemull August 23, 2024 14:21
@StephDriver StephDriver assigned joemull and unassigned mauromsl Aug 23, 2024
@joemull joemull assigned ajrbyers and unassigned joemull Aug 29, 2024
@ajrbyers ajrbyers self-requested a review August 29, 2024 12:52
@ajrbyers ajrbyers merged commit 14ec665 into master Aug 29, 2024
@ajrbyers ajrbyers deleted the 4353-article-page-sharelinks-a11y-update branch August 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants