-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4353 article page sharelinks a11y update #4355
Conversation
e457555
to
1a037ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @StephDriver, a small comment on the use of !important
and how it might impact theme styling overrides.
src/themes/material/assets/mat.css
Outdated
color: var(--twitter-hover) !important; | ||
} | ||
|
||
.twitter-bg:hover { | ||
background-color: var(--twitter-hover); | ||
color: var(--twitter) !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are adding explicit !important
colours to the 𝕏
button we should probably do the same for other ones. If not, we will introduce inconsistency wherever someone has overriden btn
colours.
e.g see https://www.comicsgrid.com/article/id/15400/
Alternatively, do not use the !important
property, though I bet you are using because the changes wouldn't take effect on the base theme styling otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right, they wouldn't work without !important
and very good point, about consistency too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hover.mov
While updating, I also realised that the X button inverting on hover was different to the other two buttons - their hover action was a very very subtle change of colour. So I updated all three to the invert behaviour.
Updated the share links across all themes for a11y.
NB the share links for Clean are buttons because of the need to meet WCAG minimum target size. More comments on this with screenshots on issue itself.
Closes #4353
which encompassed these, so it also:
Closes #3933
Closes #4340
Closes #1863