hp and defense fix #642
Merged
hp and defense fix #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsure if this has already been added elsewhere but seems like commas were the only change
|
Can confirm that health, max health and mana are fixed. Defense is still bugged when I try your pr in game. EDIT: defense is working too for your version. I'm just confused since I failed to merge your changes into my fork |
|
Can confirm it works with main branch sources(hp+def are fixed) |
- Use NumberFormat for parsing to support decimals
ILikePlayingGames
approved these changes
Aug 19, 2022
|
Absorption not fixed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if someone has already done this, but a quick fix by removing commas from hp/max hp/defense before parsing. Not sure if there's other changes to action bar