fix #714, Add process Architecture to the ps command #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, I wanted to learn a bit of golang and familiarise myself with sliver, so I thought I'd have a go at fixing #714 since it seemed straightforward.
I've opened a draft PR because I have not fully tested this, and I have not implemented macOS, but I wanted to open this as a draft pr early to get feedback.
Details
This change uses IsWow64Process on Windows and reads the elf header from
/proc/<pid>/exe
on Linux to determine the architecture. macOS is not implement yet, but I suspect it can be achieved withsysctlnametomib("sysctl.proc_cputype",...
Verification
make pb
make linux
[server] sliver > generate --http example.com --os linux
[server] sliver (NAME_HERE) > ps
Output: