Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on Ethereum related calls #169

Merged
merged 9 commits into from
Feb 13, 2018
Merged

Conversation

seland
Copy link
Contributor

@seland seland commented Feb 4, 2018

Changes

Fixed #166 (specifically undefined is not a function (evaluating ‘babelHelpers.asyncToGenerator’)).

Verification

Production build should not crash on create nation.

@seland seland added this to the Pangea 0.3.2 milestone Feb 4, 2018
@seland seland self-assigned this Feb 4, 2018
@seland seland requested a review from florianlenz February 4, 2018 19:37
App.js Outdated

// Fix for https://github.com/Bit-Nation/BITNATION-Pangea-mobile/issues/166
// Related with https://github.com/facebook/react-native/issues/4844
babelHelpers.asyncToGenerator = asyncToGenerator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to try the solution provided by "skevy" facebook/react-native#4844? I would prefere it.

@florianlenz
Copy link
Contributor

I will merge it since the latest development branch passed AFAIK

@florianlenz florianlenz merged commit dfde9e5 into develop Feb 13, 2018
@seland seland deleted the feature/166-ethereum-crash branch March 14, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants