Add support for matchphrase as long as match_phrase (rev. B)
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the parser, use tokens from the lexer instead of string literals. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
We confirmed that PPL does not need to support matchphrase variant. Signed-off-by: MaxKsyunz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev-match_phrase-#185 #51 +/- ##
========================================================
Coverage 97.67% 97.67%
Complexity 2743 2743
========================================================
Files 267 267
Lines 6807 6809 +2
Branches 437 437
========================================================
+ Hits 6649 6651 +2
Misses 157 157
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6 tasks
acarbonetto
approved these changes
May 11, 2022
forestmvey
reviewed
May 11, 2022
| @@ -35,4 +35,17 @@ void match_in_having() throws IOException { | |||
| verifyDataRows(result, rows("Bates")); | |||
| } | |||
|
|
|||
| @Test | |||
| void match_phrase_in_where() throws IOException { | |||
| JSONObject result = executeQuery("SELECT firstname WHERE match_phrase(lastname, 'Bates')"); | |||
There was a problem hiding this comment.
Don't these SELECT statements need FROM clauses?
There was a problem hiding this comment.
You are right -- removed until the tests work.
MaxKsyunz
changed the base branch from
dev-match_phrase-#185
to
integ-match_phrase-#185
MaxKsyunz
changed the base branch from
integ-match_phrase-#185
to
dev-match_phrase-#185
Signed-off-by: MaxKsyunz <[email protected]>
MaxKsyunz
force-pushed
the
dev-match_phrase-#185-matchphrase_revB
branch
from
89c44ed to
2b95ff1
Compare
Signed-off-by: MaxKsyunz <[email protected]>
MaxKsyunz
approved these changes
May 12, 2022
forestmvey
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A duplicate of #49, but based on most recent code.
The proposed changes add support for
matchphrasefunction which mapped asmatch_phrase.Issues Resolved
opensearch-project#185, p.3
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.