Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-wemix): add transaction builder #5422

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

yogeshwar-bitgo
Copy link
Contributor

Ticket: WIN-4180

@yogeshwar-bitgo yogeshwar-bitgo force-pushed the WIN-4182-wemix-txn-builder branch 3 times, most recently from 0d89088 to 45de1f8 Compare January 24, 2025 04:39
@yogeshwar-bitgo yogeshwar-bitgo marked this pull request as ready for review January 24, 2025 05:18
@yogeshwar-bitgo yogeshwar-bitgo requested review from a team as code owners January 24, 2025 05:18

describe('Wemix Transfer Builder', () => {
describe('Build from TxHex', function () {
it('Should successfully build from txHex', async function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a testcase to build a txn and asset the txn fields

Copy link
Contributor

@alebusse alebusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flushing from queue

@yogeshwar-bitgo yogeshwar-bitgo force-pushed the WIN-4182-wemix-txn-builder branch 2 times, most recently from 9379fab to e189332 Compare January 27, 2025 14:19
Copy link
Contributor

@therealdwright therealdwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the CI errors.

@yogeshwar-bitgo yogeshwar-bitgo force-pushed the WIN-4182-wemix-txn-builder branch from e189332 to a86844e Compare January 28, 2025 03:39
@yogeshwar-bitgo yogeshwar-bitgo force-pushed the WIN-4182-wemix-txn-builder branch from c544e64 to 3f7133b Compare January 28, 2025 04:43
@yogeshwar-bitgo yogeshwar-bitgo merged commit 097b45c into master Jan 28, 2025
8 checks passed
@yogeshwar-bitgo yogeshwar-bitgo deleted the WIN-4182-wemix-txn-builder branch January 28, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants