fix: replace enums with string literal types

[bitgoAaron]

• SignatureShareType, CommitmentType, and EncryptedSignerShareType converted to const objects with type exports

Ticket: CE-5160

[kaustubhbitgo]

If bundle size, performance is the issue, then instead of introducing a breaking change to replace enums with string literals we can opt for any of the following method.

1. const enum - Erases enum type completely and provides only type definition. If used then tsc replaces it with string literals.

// file.ts
export const enum CommitmentType {
  COMMITMENT = 'commitment',
  DECOMMITMENT = 'decommitment',
}

// example.ts
console.log(CommitmentType.COMMITMENT)

// example.js (after tsc build)
console.log('commitment')

2. as const - Provides readonly type definitions, less impact on bundle size since it is a direct object mapping instead of function shenanigans that enums do.

// file.ts
export const CommitmentType = {
  COMMITMENT: 'commitment',
  DECOMMITMENT: 'decommitment',
} as const;

// example.ts
console.log(CommitmentType.COMMITMENT) /* same in compiled js with less overhead */

Have you explored any of these methods?

[bitgoAaron]

If bundle size, performance is the issue, then instead of introducing a breaking change to replace enums with string literals we can opt for any of the following method.

1. const enum - Erases enum type completely and provides only type definition. If used then tsc replaces it with string literals.

// file.ts
export const enum CommitmentType {
  COMMITMENT = 'commitment',
  DECOMMITMENT = 'decommitment',
}

// example.ts
console.log(CommitmentType.COMMITMENT)

// example.js (after tsc build)
console.log('commitment')

2. as const - Provides readonly type definitions, less impact on bundle size since it is a direct object mapping instead of function shenanigans that enums do.

// file.ts
export const CommitmentType = {
  COMMITMENT: 'commitment',
  DECOMMITMENT: 'decommitment',
} as const;

// example.ts
console.log(CommitmentType.COMMITMENT) /* same in compiled js with less overhead */

Have you explored any of these methods?

good call @kaustubhbitgo , went with your suggestion & included a type export which will satisfy our needs tree shaking the UI.