Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to build installer .exe or .msi for Windows (runnable on windows 7 x64 and newer) #10

Closed
van-orton opened this issue Sep 29, 2020 · 11 comments

Comments

@van-orton
Copy link
Collaborator

van-orton commented Sep 29, 2020

Task Description

The aim of this task is to revisit creation of the Windows installable package (the Nullsoft installer is currenly used) of BGL Core. It's largely the same script and process as the Bitcoin Core installation script, with same dependencies and build process.
It uses VS2019 image to build the installation executable package.
https://github.com/wu-emma/bitgesell/blob/master/.appveyor.yml

You can create free account on AppVeyor.com at https://www.appveyor.com/

Solution steps

  • Ensure that windows build is working (including Qt wallet), this will require Visual Studio (download VS2019 Community Edition if you don't have one installed);
  • There are dependencies installed using vcpkg, but the more complicated thing is Qt, which should be installed by hand (check existing AppVeyor script link https://github.com/sipsorcery/qt_win_binary/releases/download/v1.6/Qt5.9.8_x64_static_vs2019.zip);
  • Fix dependencies or project settings (if needed) in build_msvc;
  • Sign up to AppVeyor free tier;
  • Fix AppVeyor script in .appveyor.yml

Acceptance criteria

  • AppVeyor has a free tier -- please sign up for it, project is public, so it is allowed;
  • AppVeyor can automatically build Windows installable package for Windows x64 platform;
  • Along with pull request (which probably would be rather short), provide sample of built setup executable and short notes of integrating/fetching built artifacts from AppVeyour build.
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.71 ETH (250.09 USD @ $352.24/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 1 month from now.
Please review their action plans below:

1) mul1sh has been approved to start work.

I will modify the bitcoin core installation script and have it working with BGL Core as required and also enable building the installation package from appveyor for windows. Will have this working in a week or less, thanks :)
2) jordan69420 has applied to start work (Funders only: approve worker | reject worker).

sounds good, I will find a way to make an exe

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@mul1sh Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@van-orton
Copy link
Collaborator Author

Hi @mul1sh how're you doing? How is the issue going? Hope everything's ok! Can I help with something?

@wu-emma
Copy link
Collaborator

wu-emma commented Oct 20, 2020

Hi @mul1sh how are things going? Please keep me updated, thanks!

@gitcoinbot
Copy link

gitcoinbot commented Oct 20, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@mul1sh due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mul1sh
Copy link

mul1sh commented Oct 20, 2020

@van-orton @wu-emma I had a few issues with appveyor which i'm still working through, but i'm very confident by latest this coming Friday, i'll have the script ready and this issue will be done 🙂

@wu-emma
Copy link
Collaborator

wu-emma commented Oct 21, 2020

@mul1sh Hi, ok, let's have Friday as a deadline for PR to be created.

@mul1sh
Copy link

mul1sh commented Oct 26, 2020

@wu-emma Sorry but i'll have to stop working on this issue, there were alot of issues in getting the appveyor script to produce win 7 & upwards builds i.e. the autogen file msvc-autogen.py was not producing the required files so I had to modify it a bit and a few other issues.

And still after this I keep getting errors in running the builds in win 10 x64 and other random crashes in win 7 x64 as well. So i'll stop with the issue and let someone else continue, many thanks for the patience.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.71 ETH (271.15 USD @ $381.91/ETH) attached to this issue has been cancelled by the bounty submitter

@wu-emma
Copy link
Collaborator

wu-emma commented Nov 2, 2020

Recreated as #23 to make another bounty on GitCoin

@wu-emma wu-emma closed this as completed Nov 2, 2020
wu-emma pushed a commit that referenced this issue Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants