JNG-6024 annotated false is not the negation of annotated true

[gaborflorian]

JNG-6024 __seleted field not presented on static range

[coderabbitai]

Walkthrough

The changes in this pull request focus on the RdbmsDAOImpl class, specifically modifying the conditional checks within the readRangeOf and calculateNumberRangeOf methods. The condition now checks if the reference is annotated as true for "transient," altering the logic for retrieving current references based on the markSelectedRangeItems flag and the presence of an instance ID. Minor adjustments to comments and formatting were also made, but these do not affect the overall functionality or structure of the methods.

Changes

File Path	Change Summary
judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/RdbmsDAOImpl.java	Modified conditional checks in readRangeOf and calculateNumberRangeOf methods to check for true "transient" annotations. Minor comment and formatting adjustments made.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RdbmsDAOImpl

    User->>RdbmsDAOImpl: call readRangeOf()
    RdbmsDAOImpl->>RdbmsDAOImpl: Check if reference is transient (true)
    RdbmsDAOImpl-->>User: Return current references

Loading

🐰 "In the code where rabbits hop,
A change was made, we won't stop.
From false to true, the check now sings,
Adjustments made, oh what joy it brings!
With comments clear and formatting neat,
Our logic's strong, can't be beat!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/RdbmsDAOImpl.java (1)

747-747: LGTM! The fix correctly handles transient reference annotation.

The change fixes a logical error by properly checking if the reference is annotated as true for "transient" instead of incorrectly using annotated false as the negation.

Would you like me to help create a test case to prevent regression? This could verify the behavior for both transient and non-transient references.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ff78044 and c759448.

📒 Files selected for processing (1)

• judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/RdbmsDAOImpl.java (1 hunks)