JNG-5697 On module change when different user have valid key invalida… #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noherczeg
requested changes
Apr 25, 2024
| window.location.reload(); | ||
| } | ||
| } | ||
| }, [useSearchParams, getUser]); |
There was a problem hiding this comment.
useSearchParams is not used, should not be needed in the dependencies array.
There was a problem hiding this comment.
getUser also never changes, so the dependency array should be empty I think.
| clearSecurityStorage(); | ||
| const { origin } = window.location; | ||
| window.location.href = origin + '/' + applicationKey; | ||
| window.location.href = origin + '/' + applicationKey + "?user=" + tokenUser ; |
There was a problem hiding this comment.
Since tokenUser could be an email address, we might need to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent it to make sure special characters are encoded in the param. Not sure, we should check.
| const tokenUser = profile?.preferred_username; | ||
| if (tokenUser != null && tokenUser === forcedUser) { | ||
| clearSecurityStorage(); | ||
| window.location.reload(); |
There was a problem hiding this comment.
The ?user search param should be removed before we reload I think since we won't need it any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te it