Fix beta tester deletion #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we often ran into timeouts.
Specifying filters is way more flexible since we can now search beta testers by email, firstName, lastName, … in one command call. The for loop has also been moved into ASCKit to simplify the call site in `asc`. Also the command does not end in a failure error code anymore when no testers have been found.
Heterogeneous collection literal could only be inferred to '[String : Any]'; add explicit type annotation if this is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix beta tester deletion
Now all testers are deleted that are found (before only the first one
was deleted). An additional check is implemented which determines if
the user is still in any VALID beta groups. If a user is only in
INVALID beta groups he is treated as deleted. See comment on
allValidTesterGroups.Specifying filters is way more flexible since we can now search beta
testers by email, firstName, lastName, … in one command call. 🚨 Please
use this power with caution though! Specifying just a first name will
delete all testers that share the same first name.
The for loop over all filters (previously over all emails) has been
moved from Assist to ASCKit to keep the command implementation small.
No error is thrown anymore when no testers have been found. The testers
are just not added to
allDeletedTestersresult anymore.Upgrade ASCKit to
0.2.0Increased timeout interval to 30s
Before we often ran into timeouts.
Switch input from
emails->filtersSpecifying filters is way more flexible since we can now search beta
testers by email, firstName, lastName, … in one command call.
The for loop has also been moved into ASCKit to simplify the call site
in
asc.Also the command does not end in a failure error code anymore when no
testers have been found.
Fixed a waning
Heterogeneous collection literal could only be inferred to '[String :
Any]'; add explicit type annotation if this is intentional.
Issues