Custom brjs apps location doc updates #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanged since I think the acceptance criteria for this story need to be tweaked slightly.
|
@ioanalianabalas we should update the custom apps docs so that it talks about apps being able to live anywhere now even outside of brjs-apps folder and that if we run brjs from within an app it will treat the parent directory as the apps directory regardless of what its call but add a note that we should only include apps otherwise we will be memorising all files in the parent directory |
|
BladeRunnerJS/brjs#1402 (BladeRunnerJS/brjs#1386) changes this behaviour slightly so once BladeRunnerJS/brjs#1402 is merged we should update the docs to reflect the changes. |
andy-berry-dev
changed the title
|
Closing this issue as we are modifying the behaviour to what is described in BladeRunnerJS/brjs#1408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted #96 in favour of this one, so that it will be merged into
developinstead ofgh-pages.