Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS bundler does not resolve file paths specified in IE filters #1574

Closed
willalbone opened this issue Nov 4, 2015 · 3 comments
Closed

CSS bundler does not resolve file paths specified in IE filters #1574

willalbone opened this issue Nov 4, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@willalbone
Copy link

Files paths are not being resolved inside of IE css filter properties

Raw css:

.my-class {
    background: url("images/background.png");
    background-size: contain;
    -ms-filter: "progid:DXImageTransform.Microsoft.AlphaImageLoader(src='images/background.png', sizingMethod='scale')";
}

bundle.css:

.my-class {
    background: url("../../cssresource/aspect_login/theme_custom/images/background.png");
    background-size: contain;
    -ms-filter: "progid:DXImageTransform.Microsoft.AlphaImageLoader(src='images/background.png', sizingMethod='scale')";
}

brjs version: 1.0.2-0.g11d152a

@dchambers
Copy link
Contributor

Out of interest @willalbone, why don't you just not use the filter? Alpha PNGs have been supported since IE7.

@stevesouth
Copy link
Contributor

Its similar to background-size: contain, which isn't supported.

@dchambers dchambers added the bug label Nov 4, 2015
@dchambers dchambers added this to the Current Focus milestone Nov 4, 2015
@willalbone
Copy link
Author

@stevesouth yep, that's what we're using it for

germtb pushed a commit that referenced this issue Nov 16, 2015
…erences to the url, not just the url itself. Fixes #1574
@germtb germtb self-assigned this Nov 16, 2015
thecapdan added a commit that referenced this issue Nov 18, 2015
…lve_file_paths_specified_in_IE_filters_#1574

Improved the regex that matches css urls so that it also rewrites references to the url, not just the url itsel. Fixes #1574
@andy-berry-dev andy-berry-dev modified the milestones: 1.2.0, Current Focus Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants