Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify common functionality supported across all library types #419

Closed
dchambers opened this issue Mar 18, 2014 · 2 comments
Closed

Unify common functionality supported across all library types #419

dchambers opened this issue Mar 18, 2014 · 2 comments
Labels
enhancement

Comments

@dchambers
Copy link
Contributor

The set of restrictions regarding the library type (e.g. NamespacedJs, CommonJs or Thirdparty) are too restrictive, since:

  • We don't allow requires from third-party or NamespacedJs style code.
  • We don't allow unit tests except within conformant libraries.
@leggetter
Copy link
Contributor

What's the action here?

@dchambers dchambers changed the title Functionality of each library type differs too much Unify common functionality supported across all library types Jun 12, 2014
@dchambers dchambers mentioned this issue Jun 13, 2014
Merged
dchambers pushed a commit that referenced this issue Aug 26, 2014
@hegemonic
Merge pull request #419 from ErnstHaagsman/default-tag-objects
1fb2fe0 
@default tag: added support for object literal defaults
dchambers pushed a commit that referenced this issue Aug 26, 2014
@hegemonic
temporarily disable the changes for #419
1f627da
@dchambers
Copy link
Contributor Author

@andyberry88 / @thecapdan: I believe this can now be closed as although we don't explicitly support require() in NamespacedJs code, it does now work because the trie now treats slashes and dots as the same thing. Also, it was always possible to run tests in non-con-formant libraries, despite what I said above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dchambers @leggetter @andy-berry-dev