Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New locale redirector doesn't support query strings #677

Closed
janhancic opened this issue Jun 3, 2014 · 4 comments
Closed

New locale redirector doesn't support query strings #677

janhancic opened this issue Jun 3, 2014 · 4 comments
Labels
bug high-priority size 0.5
Milestone
0.9

Comments

@janhancic
Copy link
Contributor

If you try to load an app with a URL that contains a query string (?debug=true) the new JS redirector will keep redirecting by appending the locale to the end of the URL, so the app never loads.
@andy-berry-dev andy-berry-dev added this to the 0.9.1 milestone Jun 10, 2014
andy-berry-dev pushed a commit that referenced this issue Jun 10, 2014
fixing locale-forwarder so it handles URLs with a query string - fixes …
95973c5 
…#677
@andy-berry-dev
Copy link
Member

Hey @janhancic, this has been fixed in 95973c5.

@janhancic
Copy link
Contributor Author

👍

@sospirited
Copy link
Member

How does this test expect to be run in CI?

  • I can verify that the application no longer keeps redirecting on Chrome/FF/IE(9) locally
  • I can verify that when I load the locale-forwarder-test.html in chrome, it passes (and I've seen it fail when I revert the locale-forwarder.js fix)
  • However, the html test file throws errors in Jasmine when launched in IE9 (I think it doesn't like for)

Additionally, why is this file not inside a library folder like everything else? (e.g. inside br)
CC: @thecapdan

@andy-berry-dev
Copy link
Member

@sospirited I've moved the locale forwarder into its own library in #710 so its tests can be run just like any other lib.

@andy-berry-dev andy-berry-dev modified the milestones: 0.9, 0.10 Jun 13, 2014
dchambers pushed a commit that referenced this issue Aug 26, 2014
@hegemonic
improve filename creation (#677)
873480a 
We now allow a much larger range of characters in filenames. We also URL-encode HTML links when necessary, so that everything still works when you upload the files to a web server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high-priority size 0.5
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
4 participants
@dchambers @janhancic @andy-berry-dev @sospirited