-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allows apps to push users to the locale forwarder if app locale doesnt match the users choice #804
Comments
This should maybe be a number of utilities on the locale service instead. That way the developer of the app can decide whether to immediately forward the user, ignore the difference in locale of display a warning. We already have a mechanism for determining the preferred locale and the current locale. We probably want one more method to get the locale the user should be viewing. |
failing test above should be for issue 802. can be ignored for this issue |
Now that #1186 has been done, we should add the extra requirement that require('br-locale/switcher').switchLocale('en'); for both types of multi-locale app:
|
tested locale switching with both forwarding and non-forwarding styles and both works, although found an issue with aliasing while testing this, raised #1268 |
Create a mechanism that (optionally) allows apps to push users back to the locale forwarder if the current app locale doesn't match the locale calculated from the locale cookie and browser headers.
This will allow users to refresh the page after changing their locale since after the refresh the locales wont match and the browser will be sent to the locale forwarder. It also means if locale pages are bookmarked the correct locale will ultimately still be used.
The text was updated successfully, but these errors were encountered: