Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bundle path in tests #1371

Closed
wants to merge 9 commits into from
Closed

Conversation

andy-berry-dev
Copy link
Member

Fixes #1364.

  • replacing the old legacy xyz.bundle with bundle.xyz format.
  • this is a breaking change as the JSTD XML and HTML resource services both automatically request the bundles and the URL has now changed. I tried to make it backwards compatible by falling back to the legacy bundle URL but the way JSTD behaves when running multiple test suites made the behaviour nondeterministic, it was also much slower. Because of the backwards breaking change for XML and HTML I've also removed the legacy behaviour for all bundles and removed the dead code in the bundle file creator.

This change will mean instances of the following in all JSTestDriver.conf files must change:

bundles/xml.bundle -> bundles/bundle.xml OR bundles/xml/bundle.xml
bundles/html.bundle -> bundles/bundle.html OR bundles/html/bundle.html
bundles/js.bundle -> bundles/bundle.js OR bundles/js/dev/<minification-level>/bundle.js
bundles/css.bundle -> bundles/bundle.css OR bundles/css/<theme>/bundle.css
bundles/i18n.bundle -> bundles/i18n/en.js OR bundles/i18n/<locale>.js

I've included both the logical path that's replaced each legacy path. These translate to real content paths and the content paths can be used instead, so the format for bundle paths is `bundles/. This isn't added in this PR, it's something that's been supported for a while.

@dchambers
Copy link
Contributor

Added the 4 - ReadyForTest label as we have another breaking change that we definitely do want to release (also involving mandatory changes to jsTestDriver.conf), and so this becomes as a good a time as we're ever going to have for introducing this breaking change.

@andy-berry-dev andy-berry-dev modified the milestones: 2.0.0, 1.X Sep 28, 2015
@andy-berry-dev andy-berry-dev modified the milestones: 2.0.0, Current Focus Oct 1, 2015
@@ -3,7 +3,7 @@ basepath: .

load:
- bundles/i18n/en_i18n.bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is no longer supported and will throw an error

@thecapdan
Copy link
Contributor

This needs an extensive release note since it's a breaking change. Probably should include a copy of the table above (which was incorrect) should look like this:

bundles/xml.bundle -> bundles/bundle.xml OR bundles/xml/bundle.xml
bundles/html.bundle -> bundles/bundle.html OR bundles/html/bundle.html
bundles/js/js.bundle -> bundles/bundle.js OR bundles/js/dev/<minification-level>/bundle.js
bundles/css/css.bundle -> bundles/bundle.css OR bundles/css/<theme>/bundle.css
bundles/i18n/i18n.bundle -> bundles/i18n/<locale>.js
bundles/i18n/<locale>_i18n.bundle -> bundles/i18n/<locale>.js

@andy-berry-dev
Copy link
Member Author

See #1364 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use the new form of bundle paths in tests
3 participants