Fixed a bug for TooltipControl.js where the tooltip would not render correctly #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly It is expected behaviour that if the element that the tooltip needs to attach itself to is not visible, the tooltip will not render at all. But if the tooltip needs to visible immediately when the page loads and the parent element is not visible yet, the tooltip will not render For that reason, we need to delay execution until rendering is complete
|
Hey @dogoku, thanks for the PR. Could you also write a test to go with the change? Thanks! |
|
@andyberry88, apparently this change can only be seen in CT, and is not easy to replicate in BRJS, so I was inclined to allow it through provided it could be manually tested with CT. However, I've just looked at the code and seen that the fix is to use a @dogoku, can't your code wait on some underlying event, and in fact wouldn't that then make it more testable? |
|
I'm pretty sure this has already been fixed by #1378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is expected behaviour that if the element that the tooltip needs to attach itself to is not visible, the tooltip will not render at all.
But if the tooltip needs to visible immediately when the page loads and the parent element is not visible yet, the tooltip will not render.
For that reason, we need to delay execution until rendering is complete
This is easy to test in CT. Please talk to me for a url